Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collision errors when introducing history plugin after the fact #991

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tarzan
Copy link

@tarzan tarzan commented Mar 30, 2022

I've redone the work of #850

The problem that still exists in this current version is:

  1. implement the friendly_id slugs
  2. figuring out somewhere along the line that you want the history plugin as well
  3. create a new sluggable record that would translate to an already existing slug
  4. fails with a database constraint on unique slugs

The method 'scope_for_slug_generator' did a bit too much work with an inner join that made existing records with no entry in the history table being filtered out.

@stale

This comment was marked as resolved.

@stale stale bot added the stale label Jul 10, 2022
@parndt parndt added the pinned label Jul 21, 2022
@parndt
Copy link
Collaborator

parndt commented Jul 21, 2022

Thank you for redoing this @tarzan 😄

@stale stale bot removed the stale label Jul 28, 2022
@tarzan
Copy link
Author

tarzan commented Oct 18, 2022

Thank you for redoing this @tarzan 😄

Before this becoming stale again: anything keeping you from merging this?

@parndt
Copy link
Collaborator

parndt commented Nov 15, 2022

I think it's good @tarzan

@norman can you think of any gotchas here? I've not used the history plugin before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants