fix #5034. Apply Vector Field Node performance proposal solution #5035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @portnov. Can you review this solution? |
|
What about other SvSurface implementations? |
|
I did not know about this class. Do you have a plan for this class? |
|
You can try to write generic implementation of your method in base SvSurface class. Maybe it is possible to do it efficiently. Other possible solution is to implement it in each SvSurface implementation, with specific optimizations in each class; but that would be some amount of work. |
…3. Escape calculation of vertices by polimorphizm. Some 'normal_array' of surface calcs source vertices so there is no need calc vertices by evaluate_array. So written function 'normal_vertices_array' is SvSurface and in some inheritance classes that return both params if needed.
|
@portnov Thank you! |
satabol
deleted the
fix_5034_Apply_Vector_Field_Node_performance_proposal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5034. Apply Vector Field Node performance proposal solution
In general 9356ms to 582ms is 16 times. (refactor to numpy)
Example in real time: (on my computer)
File for tests:
fix_5034_Apply_Vector_Field_Node_performance_proposal.v001_51160_autosave.blend.zip
P.S.
Comment to the future: If refactor some spline's library functions one can do more performance. I think this code can be optimized too: