Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update websocket-polyfill to v1.0.0 #231

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hzrd149
Copy link

@hzrd149 hzrd149 commented May 22, 2024

This updates websocket-polyfill to 1.0.0

The package is technically deprecated but the 1.0.0 version now relies on the popular ws package instead of a custom WebSocket implementation

https://www.npmjs.com/package/websocket-polyfill/v/1.0.0

@erskingardner
Copy link
Collaborator

I tried to do this a while ago and it breaks NDK. I can't remember exactly what happened at the time (and maybe it's fixed now?)

@jeremyd
Copy link
Contributor

jeremyd commented Jun 26, 2024

I thought we got rid of websocket-polyfill..?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants