Merge pull request #47 from yonzilch/main

Improve LightHouse Score
not-matthias · Mar 26, 2024 · cf10a8b · cf10a8b
2 parents 756dbc2 + 6f44913
commit cf10a8b
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/config.toml b/config.toml
@@ -1,5 +1,6 @@
 base_url = "https://not-matthias.github.io/apollo/"
 title = "not-matthias"
+description = "This is an example description"
 build_search_index = false
 generate_feed = true
 compile_sass = true

diff --git a/templates/base.html b/templates/base.html
@@ -1,6 +1,7 @@
 {% import "macros/macros.html" as post_macros %}
 
 <!DOCTYPE html>
+<html lang="en">
 <html class="dark light">
 
 {% include "partials/header.html" %}

diff --git a/templates/macros/macros.html b/templates/macros/macros.html
@@ -18,7 +18,8 @@ <h1 class="page-title">All articles</h1>
 {% macro list_posts(pages) %}
 <ul>
     {%- for page in pages %}
-    <section class="list-item">
+    <li class="list-item">
+    <section>
         <div class="post-header">
             <time>{{ page.date | date(format="%Y-%m-%d") }}</time>
 
@@ -49,7 +50,7 @@ <h1 class="title">
             </div>
         </div>
     </section>
-
+  </li>
     {% endfor -%}
 </ul>
 {% endmacro list_posts %}
@@ -202,7 +203,7 @@ <h1 class="card-title">
                 <div class="card-description">
                     {% if page.description %}
                         {{ page.description }}
-                    {% endif %}
+                    {% endif %} 
                 </div>
             </div>
         </div>

diff --git a/templates/partials/nav.html b/templates/partials/nav.html
@@ -17,9 +17,9 @@
         {% endfor %}
 
         {% if config.extra.theme == "toggle" %}
-        | <a id="dark-mode-toggle" onclick="toggleTheme()" href="javascript:void(0)">
-            <img src={{ get_url(path="feather/sun.svg") }} id="sun-icon" style="filter: invert(1);" />
-            <img src={{ get_url(path="feather/moon.svg") }} id="moon-icon" />
+        <a id="dark-mode-toggle" onclick="toggleTheme(); event.preventDefault();" href="#">
+            <img src={{ get_url(path="feather/sun.svg") }} id="sun-icon" style="filter: invert(1);" alt="Light" />
+            <img src={{ get_url(path="feather/moon.svg") }} id="moon-icon" alt="Dark" />
         </a>
         <script src={{ get_url(path="js/themetoggle.js") }}></script>
         {% endif %}