Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new Norwegian translation #68

Closed

Conversation

Njardarheim-1337
Copy link

No description provided.

@Need74
Copy link

Need74 commented Jul 26, 2024

Hello
for a better effect and to align the double points, make this change:

<MSGID_VERSIONCURRENT content="Gjeldende installert versjon&#x9;:"/>
<MSGID_VERSIONNEW content=" &#xD;Tilgjengelig versjon&#x9;:"/>

You can also put 5.3.0 for the version which will differentiate the future versions
Regards

@Njardarheim-1337
Copy link
Author

Thanks @Need74 .
I have done the two changes you suggested if I understood correct.
Please advice if I misunderstood as I am new to contributing.

@Need74
Copy link

Need74 commented Jul 26, 2024

Thanks @Need74 . I have done the two changes you suggested if I understood correct. Please advice if I misunderstood as I am new to contributing.

Hi
I made a PR for the english.xml file but I'm not sure if it was taken into account.
I made also a PR for french.xml witch is in progress.
That's why I encouraged you to make the change in the Norwegian file.
I'm also new to GitHub and I don't master everything.
However, it's a pleasure to share in the world of free software.
For your file I think it is correct and if you want to see the result you can edit the local file on your computer at:
C:\Program Files\Notepad++\updater\nativeLang.xml and paste the content of the modified file.
However you must run Notepad++ with an old version (before 8.6.7) to have the update dialog available that appears. (It is not mandatory to reinstall Notepad++ in full but simply to launch the Notepad++.exe file of the old version recovered from a npp.8.6.x.Installer.x64.exe file by extracting it with 7Zip. But you must run it from Program Files)

Now you just have to wait than DonHo look at your work and validate the PR.
Best regards

@donho donho self-assigned this Aug 10, 2024
@donho donho added the accept label Aug 22, 2024
@donho donho closed this in 918e3d5 Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants