HTTP parsing updates for RFC 9112 #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no functional change.
space; reject various invalid chunk-size lines. * src/ne_request.c (read_message_line): New function. (read_response_block): Stricter chunk-line parsing. (read_status_line, read_message_header): Use read_message_line. (strip_eol): Removed function. * test/request.c (response_bodies, response_headers): Add tests for plain CR parsing. (fail_on_invalid): Add invalid chunked responses, add debugging. (ipv6_literal): Simplify.
no functional change.
status-line. (ne_begin_request): Simplify, assume HTTP major version is 1. * test/request.c (fail_on_invalid): Test for non-HTTP/1.x responses.
* src/ne_request.c: Add table_http_token lookup table. (read_response_headers): Use it to parse a token as the field-name. Don't allow whitespace BEFORE the colon. * src/mktable.c (gen_token, main): New generator. * test/request.c (response_headers, fail_on_invalid): New tests for valid/invalid response headers.
notroj
force-pushed
the
http-parsing-rfc9112
branch
from
df3319a
to
538851c
Compare
no effect but can be used to relax any HTTP parsing strictness as required for interoperability. * src/ne_session.h (ne_session_flag): Add NE_SESSFLAG_STRICT. * src/ne_session.c (ne_session_create): Enable NE_SESSFLAG_STRICT by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.