Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit hooks #1982

Merged
merged 18 commits into from
Aug 24, 2023
Merged

Commit hooks #1982

merged 18 commits into from
Aug 24, 2023

Conversation

stepanLav
Copy link
Member

@stepanLav stepanLav commented Aug 22, 2023

This PR adds:

  • Use make for prepare environment
  • Use poetry for dependency
  • Use pre-commit for git hooks

Git hooks:

  • Trims trailing whitespace.
  • Makes sure files end in a newline and only a newline.
  • Attempts to load all json files to verify syntax.
  • Custom hook, which check that chains.json:
    • do not have duplicates in assets
    • do not have duplicates in nodes

hook examples:
Screenshot 2023-08-23 at 02 09 14
Screenshot 2023-08-23 at 02 08 29
Screenshot 2023-08-23 at 02 07 31

@stepanLav stepanLav changed the title Feat/adding_git_hooks Commit hooks Aug 22, 2023
@stepanLav stepanLav merged commit 2e069c4 into master Aug 24, 2023
@stepanLav stepanLav deleted the feat/adding_git_hooks branch August 24, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants