Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auto-scroll on provider sidebar [NV-3745] #5531

Merged
merged 2 commits into from
May 9, 2024

Conversation

ChmaraX
Copy link
Contributor

@ChmaraX ChmaraX commented May 9, 2024

What changed? Why was the change needed?

  • clicking on the provider tile didn't scroll to the selected section in the sidebar
  • coming directly from the URL didn't scroll to the section
  • in some cases scrollTo was not able to find element in the DOM because it didn't yet exist, since the providers are rendered asynchronously
  • scrollTo query param was not updating

Screenshots

Before:

before.mp4

After:

after.mp4

@ChmaraX ChmaraX requested a review from a team May 9, 2024 08:08
Copy link

linear bot commented May 9, 2024

Copy link

netlify bot commented May 9, 2024

Deploy Preview for novu-design ready!

Name Link
🔨 Latest commit 0250ea8
🔍 Latest deploy log https://app.netlify.com/sites/novu-design/deploys/663c8473aa089b000996316d
😎 Deploy Preview https://deploy-preview-5531--novu-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 9, 2024

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit 0250ea8
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/663c8473f851750008039593
😎 Deploy Preview https://deploy-preview-5531--dev-web-novu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@scopsy scopsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Fantastic!

@ChmaraX ChmaraX merged commit 4524b7b into next May 9, 2024
25 checks passed
@ChmaraX ChmaraX deleted the nv-3745-fix-auto-scroll-on-channel-selector-sidebar branch May 9, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants