-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multichart #1938
base: master
Are you sure you want to change the base?
Multichart #1938
Conversation
This PR contains changes to historicalBar.js too. Please keep each PR containing only a single feature or bugfix, thanks! |
I'm not sure what options I have left. If one would like to have two bars and lines showing historical data he must use The only option I see is to prepare completely new bar model inspired by |
I guess I don't understand why the changes to historicalBar.js were needed then. Can you explain it more? |
In my case I wanted to use Unfortunately historicalBar was designed to be the only one on the chart. When two historicalBars were set there were errors with tooltips. My modification hopefully doesn't break anything else and provide an option to use Only other option I see is to create |
Multichart was added options
barModel
andxScale
. Now one can usehistoricalBar
in multichart which plays well with lines and additional bars: grids are aligned with bars.