refactor: Remove unused code and optimize QueryBuilder class

composer.json

@@ -17,6 +17,7 @@
         "laravel/pint": "^1.13.7",
         "pestphp/pest": "^2.28.1",
         "phpstan/phpstan": "^1.10.50",
+        "rector/rector": "^0.19.2",
         "symfony/var-dumper": "^6.4.0|^7.0.0"
     },
     "autoload": {
@@ -44,7 +45,7 @@
         "test:refacto": "rector --dry-run",
         "test:lint": "pint --test",
         "test:types": "phpstan analyse --ansi",
-        "test:unit": "pest --colors=always",
+        "test:unit": "pest",
         "test": [
             "@test:refacto",
             "@test:lint",

src/Query.php

@@ -7,11 +7,11 @@
 use GuzzleHttp\Exception\GuzzleException;
 use KCNetwork\Liquipedia\Query\QueryBuilder;
 
-class Query extends QueryBuilder
+final class Query extends QueryBuilder
 {
-    protected Client $client;
+    private readonly Client $client;
 
-    protected string $endpoint;
+    private string $endpoint;
 
     /**
      * @param  array<string, mixed>  $params
@@ -68,7 +68,7 @@ public function removeWiki(string $wiki): self
             str_replace(
                 $wiki,
                 '',
-                $this->params['wiki']
+                (string) $this->params['wiki']
             )
         );
 

src/Query/QueryBuilder.php

@@ -4,14 +4,12 @@
 
 abstract class QueryBuilder implements QueryBuilderInterface
 {
-    /**
-     * @var array<string, mixed>
-     */
-    protected array $params;
-
-    public function __construct(array $params = [])
-    {
-        $this->params = $params;
+    public function __construct(
+        /**
+         * @var array<string, mixed>
+         */
+        protected array $params = []
+    ) {
     }
 
     public function build(): array

src/Query/QueryParameter.php

@@ -0,0 +1,57 @@
+<?php
+
+namespace KCNetwork\Liquipedia\Query;
+
+use stdClass;
+
+class QueryParameter implements QueryParametersInterface
+{
+    private stdClass $params;
+
+    public function __construct(array $params = [])
+    {
+        $this->params = (object) $params;
+
+        foreach ($this->params as $key => $value) {
+            $this->generateMethod($key);
+        }
+    }
+
+    private function generateMethod(string $key): void
+    {
+        $methodName = 'get'.ucfirst($key);
+        $this->{$methodName} = fn () => $this->params->{$key};
+    }
+
+    public function toArray(): array
+    {
+        return (array) $this->params;
+    }
+
+    public function __toString(): string
+    {
+        return json_encode($this->params, JSON_THROW_ON_ERROR);
+    }
+
+    public function __get(string $name): mixed
+    {
+        return $this->params->{$name};
+    }
+
+    public function __set(string $name, mixed $value): void
+    {
+        $this->params->{$name} = $value;
+        $this->generateMethod($name);
+    }
+
+    public function __isset(string $name): bool
+    {
+        return isset($this->params->{$name});
+    }
+
+    public function __unset(string $name): void
+    {
+        unset($this->params->{$name});
+        unset($this->{'get'.ucfirst($name)});
+    }
+}

src/Query/QueryParametersInterface.php

@@ -0,0 +1,42 @@
+<?php
+
+namespace KCNetwork\Liquipedia\Query;
+
+use JsonException;
+
+interface QueryParametersInterface
+{
+    /**
+     * Returns the parameters as an array
+     *
+     * @return array<string, mixed>
+     */
+    public function toArray(): array;
+
+    /**
+     * Returns the parameters as a json string
+     *
+     * @throws JsonException
+     */
+    public function __toString(): string;
+
+    /**
+     * Returns the value of the parameter
+     */
+    public function __get(string $name): mixed;
+
+    /**
+     * Sets the value of the parameter
+     */
+    public function __set(string $name, mixed $value): void;
+
+    /**
+     * Checks if the parameter is set
+     */
+    public function __isset(string $name): bool;
+
+    /**
+     * Unsets the parameter
+     */
+    public function __unset(string $name): void;
+}

tests/QueryParameterTest.php

@@ -0,0 +1,10 @@
+<?php
+
+use KCNetwork\Liquipedia\Query\QueryParameter;
+
+it('it can be instantiated', function () {
+    $queryParameter = new QueryParameter();
+
+    expect($queryParameter)->toBeInstanceOf(QueryParameter::class);
+});
+