NIST-BRSKI policy app using claim cascade system #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added various functions including VC upload, prolog queries, and email authentication
Note to self: things on the framework laptop are larger than they seem
Update branch
…ormationBoard component
…m' of https://github.com/nqminds/trustnetz into 70-implement-brski-policy-app-using-claim-cascade-system
… prolog (doesn't work yet)
…dpoint to check if a given device id can connect to network
AshleySetter
requested changes
Sep 4, 2024
| ); | ||
| }; | ||
|
|
||
| export default withAuth(Page); |
There was a problem hiding this comment.
This page.js and the page.js for device_id look very similar, could we extract some of the common code as components to be reused across both pages?
Comment on lines
105
to
126
| const data = { | ||
| "@context": ["https://www.w3.org/ns/credentials/v2"], | ||
| id: "urn:uuid:91cf3009-28ee-488e-8ae8-a751a289c8cb", | ||
| type: ["VerifiableCredential", "UserCredential"], | ||
| issuer: "urn:uuid:8bbabf61-758b-4bcb-8dab-4a4d1d493e25", | ||
| validFrom: "2024-07-25T19:23:24Z", | ||
| credentialSchema: { | ||
| id: "https://github.com/nqminds/ClaimCascade/blob/claim_verifier/packages/claim_verifier/user.yaml", | ||
| type: "JsonSchema", | ||
| }, | ||
| credentialSubject: { | ||
| type: "fact", | ||
| schemaName: "device_trust", | ||
| id: uuidv4(), | ||
| timestamp: 1716287268891, | ||
| fact: { | ||
| device_id: params.device_id, | ||
| authoriser_id: emailAddress, | ||
| created_at: Date.now(), | ||
| }, | ||
| }, | ||
| }; |
| ); | ||
| }; | ||
|
|
||
| export default withAuth(Page); |
There was a problem hiding this comment.
Once again, very similar to the other page.js components for device and device_type, could we extract common components? Or even make the page a common component itself and only differentiate the 3 with props?
Changes
Notes
|
AshleySetter
approved these changes
Sep 6, 2024
A9-dev
deleted the
70-implement-brski-policy-app-using-claim-cascade-system
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup
Install node dependencies with
npm iin/packages/cahn_demo/clientand/packages/cahn_demo/server.Run the client in
/packages/cahn_demo/clientwithnpm run dev.Run the server in
/packages/cahn_demo/serverwithnpm run dev.(Sorry, couldn't get npm workspaces to work for some reason)
Ensure you have populated the
/packages/cahn_demo/server/.envfile, according to the template found in/packages/cahn_demo/server/.env_example.Notes
There is much clean up to be done with this code. However, it should be functionally correct.