Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrf noup] Clean Kconfig.defaults to support "Thread and Wi-Fi" builds #360

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

Damian-Nordic
Copy link
Contributor

  1. Group Kconfig options into categories to make it easier to see discrepancies between Thread and Wi-Fi and help choose the right value when both transports are enabled.

    That is, prefer:

    config A
      default X if CHIP_WIFI
      default Y if NET_L2_OPENTHREAD
    

    over:

    if CHIP_WIFI
    config A
      default X
    endif
    
    if NET_L2_OPENTHREAD
    config A
      default Y
    endif
    
  2. Remove redundant defaults that are already selected in other Kconfig files.

  3. Enable SHA1 for Wi-Fi

Copy link
Collaborator

@LuDuda LuDuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! Thank you so much!

Just a question: Are we able to easily check (other than in manual way) if some of the configuration in Kconfig.defaults are not necessary anymore? For example with introduction of SHELL_MINIMAL i do see now, that i could have removed KERNEL_SHELL config. I bet, some other configs are not needed anymore as well.

@Damian-Nordic
Copy link
Contributor Author

This is fantastic! Thank you so much!

Just a question: Are we able to easily check (other than in manual way) if some of the configuration in Kconfig.defaults are not necessary anymore? For example with introduction of SHELL_MINIMAL i do see now, that i could have removed KERNEL_SHELL config. I bet, some other configs are not needed anymore as well.

I don't know, we would need to write a script that removes random configs and checks if .config hasn't changed, but I'm not aware of such a tool.

1. Group Kconfig options into categories to make it easier
   to see discrepancies between Thread and Wi-Fi and help
   choose the right value when both transports are enabled.

   That is, prefer:

   config A
     default X if CHIP_WIFI
     default Y if NET_L2_OPENTHREAD

   over:

   if CHIP_WIFI
   config A
     default X
   endif

   if NET_L2_OPENTHREAD
   config A
     default Y
   endif
2. Remove redundant defaults that are already selected in
   other Kconfig files.

Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
@Damian-Nordic Damian-Nordic merged commit 3c7f9a6 into nrfconnect:master Nov 29, 2023
7 checks passed
@Damian-Nordic Damian-Nordic deleted the thread_and_wifi_config branch November 29, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants