[nrf noup] Versioning with VERSION file for matter implemented #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkasperczyk-no
approved these changes
Dec 20, 2023
Damian-Nordic
approved these changes
Dec 20, 2023
ArekBalysNordic
approved these changes
Dec 20, 2023
LuDuda
approved these changes
Dec 28, 2023
LipinskiPNordicSemi
force-pushed
the
version-file
branch
from
8029a5c
to
47af611
Compare
ArekBalysNordic
force-pushed
the
version-file
branch
from
47af611
to
d27b794
Compare
|
Rebased. |
This commit adds posibility to use VERSION file which will work properly for DFU SMP and Matter OTA. Signed-off-by: Patryk Lipinski <patryk.lipinski@nordicsemi.no>
LipinskiPNordicSemi
force-pushed
the
version-file
branch
from
d27b794
to
9c4180a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds possibility to use VERSION file which will work properly for DFU SMP and Matter OTA.
Users still can use CHIP_DEVICE_SOFTWARE_VERSION or MCUBOOT_IMGTOOL_SIGN_VERSION config.
These changes disable Kconfig for Matter OTA values only when VERSION file is created in the app directory.