Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrf noup] Update Mbed TLS config file defines #384

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

vili-nordic
Copy link
Contributor

MBEDTLS_USER_CONFIG_FILE has been replaced with MBEDTLS_PSA_CRYPTO_CONFIG_FILE and MBEDTLS_PSA_CRYPTO_USER_CONFIG_FILE. This commit updates Matter's CMakeLists to reflect this.

Needed for upmerge nrfconnect/sdk-nrf#13662

Copy link
Collaborator

@LuDuda LuDuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but we would like to run nightly tests on manifest PR today.

MBEDTLS_USER_CONFIG_FILE has been replaced with MBEDTLS_PSA_CRYPTO_CONFIG_FILE
and MBEDTLS_PSA_CRYPTO_USER_CONFIG_FILE. This commit updates Matter's CMakeLists
to reflect this.

Also some legacy APIs are provided by PSA now, so we always propagate PSA config files.

Signed-off-by: Vidar Lillebø <vidar.lillebo@nordicsemi.no>
CHIPCryptoPALmbedTLS.cpp use functions guarded by MBEDTLS_PKCS5_C
so we enable this option.

Signed-off-by: Vidar Lillebø <vidar.lillebo@nordicsemi.no>
@carlescufi carlescufi merged commit c36fcaf into nrfconnect:master Feb 16, 2024
8 checks passed
@LuDuda
Copy link
Collaborator

LuDuda commented Feb 16, 2024

Approving, but we would like to run nightly tests on manifest PR today.

Btw. We have not found regression (in functionality) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants