-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrf noup] BLE Extended Advertisement option (#31532) #386
Merged
markaj-nordic
merged 2 commits into
nrfconnect:master
from
LipinskiPNordicSemi:ble-extended
Feb 21, 2024
Merged
[nrf noup] BLE Extended Advertisement option (#31532) #386
markaj-nordic
merged 2 commits into
nrfconnect:master
from
LipinskiPNordicSemi:ble-extended
Feb 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LipinskiPNordicSemi
requested review from
kkasperczyk-no,
ArekBalysNordic and
markaj-nordic
February 12, 2024 09:36
LipinskiPNordicSemi
force-pushed
the
ble-extended
branch
from
February 13, 2024 14:51
1eb011e
to
c9ed878
Compare
LipinskiPNordicSemi
changed the title
[nrf fromtree][TCR] Extended Announcement additions (#31532)
[nrf noup] BLE Extended Advertisment option (#31532)
Feb 13, 2024
LipinskiPNordicSemi
force-pushed
the
ble-extended
branch
from
February 13, 2024 14:58
c9ed878
to
0a7f833
Compare
LipinskiPNordicSemi
changed the title
[nrf noup] BLE Extended Advertisment option (#31532)
[nrf noup] BLE Extended Advertisement option (#31532)
Feb 13, 2024
LipinskiPNordicSemi
force-pushed
the
ble-extended
branch
from
February 13, 2024 15:07
0a7f833
to
2c80d09
Compare
LuDuda
reviewed
Feb 13, 2024
LipinskiPNordicSemi
force-pushed
the
ble-extended
branch
from
February 14, 2024 14:54
2c80d09
to
9688a76
Compare
LipinskiPNordicSemi
force-pushed
the
ble-extended
branch
from
February 14, 2024 14:57
9688a76
to
9130919
Compare
Damian-Nordic
approved these changes
Feb 14, 2024
LipinskiPNordicSemi
force-pushed
the
ble-extended
branch
3 times, most recently
from
February 15, 2024 08:11
323a56a
to
9b80351
Compare
LipinskiPNordicSemi
force-pushed
the
ble-extended
branch
3 times, most recently
from
February 15, 2024 14:26
33ad53a
to
e7659df
Compare
* additions to support changes as discussed in connectedhomeip-spec #7825 * add Silabs platform example implementation * add extension for ExtendedAnnouncementFlag + Silabs platform usage * Restyled by clang-format * adjust based on review comments - 1 * Restyled by clang-format * add missing include guard for default case * Revert "Restyled by clang-format" This reverts commit 6d3f9e107de9a8421524437f44c2113730e52e54. * fix extra bracket causing a bug + restyle changes * Restyled by clang-format * adjust based on review comments - 2 * Restyled by clang-format --------- Cherry picked from: ca17912 Co-authored-by: Restyled.io <commits@restyled.io>
This commit implements solution for new config CHIP_DEVICE_CONFIG_BLE_EXT_ADVERTISING which allow device to be visibly longer for the commissioning. Signed-off-by: Patryk Lipinski <patryk.lipinski@nordicsemi.no>
markaj-nordic
force-pushed
the
ble-extended
branch
from
February 21, 2024 11:28
e7659df
to
ad4c6fd
Compare
Damian-Nordic
approved these changes
Feb 21, 2024
ArekBalysNordic
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements solution for new config CHIP_DEVICE_CONFIG_BLE_EXT_ADVERTISING which allow device to be visibly longer for the commissioning.
Cherry-picked PR content:
additions to support changes as discussed in connectedhomeip-spec #7825
add Silabs platform example implementation
add extension for ExtendedAnnouncementFlag + Silabs platform usage
Restyled by clang-format
adjust based on review comments - 1
Restyled by clang-format
add missing include guard for default case
Revert "Restyled by clang-format"
This reverts commit 6d3f9e107de9a8421524437f44c2113730e52e54.
fix extra bracket causing a bug + restyle changes
Restyled by clang-format
adjust based on review comments - 2
Restyled by clang-format