[nrf noup] [zephyr] Allow BLE advertising restarts #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
markaj-nordic
commented
Feb 16, 2024
markaj-nordic
commented
- allow BLE advertising restarts in case of failures
- which can be triggered by calling SetBLEAdvertisingEnabled(true) ConnectivityMgr public API from the application code
- do not register CHIPoBLE GATT services when the advertising cannot be started
- this allows the disconnection handler to filter out non-Matter BLE connections that were terminated
- fix possible underflow of connection counters
* allow BLE advertising restarts in case of failures * which can be triggered by calling SetBLEAdvertisingEnabled(true) ConnectivityMgr public API from the application code * do not register CHIPoBLE GATT services when the advertising cannot be started * this allows the disconnection handler to filter out non-Matter BLE connections that were terminated * fix possible underflow of connection counters Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no>
markaj-nordic
requested review from
LuDuda,
kkasperczyk-no,
Damian-Nordic and
ArekBalysNordic
kkasperczyk-no
approved these changes
Feb 20, 2024
markaj-nordic
changed the title
ArekBalysNordic
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.