[nrf noup] Adapt Matter SDK to te WiFi FW patch on external flash #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ArekBalysNordic
force-pushed
the
wifi_ext_patch
branch
from
70300de
to
1efe42d
Compare
| @@ -122,7 +122,10 @@ config PCD_APP | |||
| default y | |||
|
|
|||
| config UPDATEABLE_IMAGE_NUMBER | |||
| default 2 | |||
| default 3 | |||
There was a problem hiding this comment.
How does this work for apps that use only two updateable images? Looking at the mcuboot code, I think it may fail if flash_area_open fails for image 2.
There was a problem hiding this comment.
Yeah, it was added here only for testing purposes, I'm still considering how we can manage that properly.
ArekBalysNordic
force-pushed
the
wifi_ext_patch
branch
from
1efe42d
to
c847afe
Compare
ArekBalysNordic
force-pushed
the
wifi_ext_patch
branch
2 times, most recently
from
793c0cd
to
640135e
Compare
Damian-Nordic
approved these changes
Feb 21, 2024
kkasperczyk-no
approved these changes
Feb 21, 2024
ArekBalysNordic
force-pushed
the
wifi_ext_patch
branch
2 times, most recently
from
ffbc5b5
to
ee0db05
Compare
LuDuda
approved these changes
Feb 25, 2024
ArekBalysNordic
force-pushed
the
wifi_ext_patch
branch
from
ee0db05
to
7aa80a3
Compare
This commit sets the default kconfigs if the WiFi FW patch on external flash is enabled.
ArekBalysNordic
force-pushed
the
wifi_ext_patch
branch
from
7aa80a3
to
5c4da22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit sets the default kconfigs if the WiFi FW patch on external flash is enabled.
This is not the final solution, for now for testing purposes only.