Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrf fromtree] Make TestEventTrigger delegate testable and extensible #414

Merged

Conversation

ArekBalysNordic
Copy link
Contributor

… (#31724)

  • Make TestEventTrigger delegate testable and extensible
  • Make TestEventTriggerDelegate base class manage multiple sub-handlers.
  • Add unit tests for TestEventTriggerDelegate
  • Introduce an interface for generic TestEventTrigger handlers
  • Add Clear() method to Intrusive list to remove everything.
  • Document the fact that emberAfHandleEventTrigger should NOT be used
  • Update all examples as needed.
    • Renumber OTA and SmokeCO testevent trigger prefix to match new Matter 1.3 standard (first 16 bits == cluster ID being tested).
    • Clean-up dead code
    • Register OTA test event handler as intended.
  • Add TODOs for platforms to clean-up TestEventTriggerDelegate registration.
  • Updated BOOLCFG tests to use --hex-arg for PIXIT since --int-arg is too confusing with complex keys.

Issue #31723

Testing done:

  • EEVSE Python tests using event triggers pass
  • SMOKECO YAML tests using event triggers pass
  • BOOLCFG Python tests using event triggers pass
  • TC_TestEventTrigger passes
  • New unit tests pass
  • Fix merge issue

  • Restyled by clang-format

  • Fix uninitialized variable access

  • Fix Ameba/Silabs build

  • Fix CopyString bound

  • More fixes of Ameba/Silabs build


Co-authored-by: Restyled.io commits@restyled.io

cherry-picked from: 4cd1825

@ArekBalysNordic ArekBalysNordic force-pushed the event_triggers_cp branch 5 times, most recently from 3cd125d to c24df40 Compare March 22, 2024 08:41
… (#31724)

* Make TestEventTrigger delegate testable and extensible

- Make TestEventTriggerDelegate base class manage multiple sub-handlers.
- Add unit tests for TestEventTriggerDelegate
- Introduce an interface for generic TestEventTrigger handlers
- Add Clear() method to Intrusive list to remove everything.
- Document the fact that `emberAfHandleEventTrigger` should NOT be used
- Update all examples as needed.
  - Renumber OTA and SmokeCO testevent trigger prefix to match new Matter 1.3
    standard (first 16 bits == cluster ID being tested).
  - Clean-up dead code
  - Register OTA test event handler as intended.
- Add TODOs for platforms to clean-up TestEventTriggerDelegate registration.
- Updated BOOLCFG tests to use `--hex-arg` for PIXIT since `--int-arg` is too
  confusing with complex keys.

Issue #31723

Testing done:
- EEVSE Python tests using event triggers pass
- SMOKECO YAML tests using event triggers pass
- BOOLCFG Python tests using event triggers pass
- TC_TestEventTrigger passes
- New unit tests pass

* Fix merge issue

* Restyled by clang-format

* Fix uninitialized variable access

* Fix Ameba/Silabs build

* Fix CopyString bound

* More fixes of Ameba/Silabs build

---------

Co-authored-by: Restyled.io <commits@restyled.io>

Cherry-picked from: 4cd1825
@ArekBalysNordic ArekBalysNordic merged commit 70be330 into nrfconnect:master Mar 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants