Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrf fromlist][nrfconnect] Improve CHIP_MEMORY_PROFILING config #418

Conversation

ArekBalysNordic
Copy link
Contributor

Enabled the full SHELL option when memory profiling is enabled.

config/nrfconnect/chip-module/Kconfig.features Outdated Show resolved Hide resolved
config/nrfconnect/chip-module/Kconfig.features Outdated Show resolved Hide resolved
@Damian-Nordic
Copy link
Contributor

Also, can you please describe why SHELL_MINIMAL is undesired? It doesn't seem related to the profiling feature.

@ArekBalysNordic
Copy link
Contributor Author

Also, can you please describe why SHELL_MINIMAL is undesired? It doesn't seem related to the profiling feature.

It was requested by QA to have it because it helps with using all SHELL components like KERNEL_SHELL, CHIP_SHELL, and NET_SHELL.

- Enabled the full SHELL option when memory profiling is enabled.
@ArekBalysNordic ArekBalysNordic merged commit f91ffce into nrfconnect:master Apr 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants