-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[scripts] Fixed nrfconnect factory generation scripts #419
Merged
kkasperczyk-no
merged 1 commit into
nrfconnect:master
from
kkasperczyk-no:merge_factory_data_scripts
Apr 8, 2024
Merged
[scripts] Fixed nrfconnect factory generation scripts #419
kkasperczyk-no
merged 1 commit into
nrfconnect:master
from
kkasperczyk-no:merge_factory_data_scripts
Apr 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
config
scripts
labels
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please notice, that the error in Github Action is relevant to this PR. :)
scripts/tools/nrfconnect/generate_nrfconnect_chip_factory_data.py
Outdated
Show resolved
Hide resolved
scripts/tools/nrfconnect/generate_nrfconnect_chip_factory_data.py
Outdated
Show resolved
Hide resolved
scripts/tools/nrfconnect/generate_nrfconnect_chip_factory_data.py
Outdated
Show resolved
Hide resolved
kkasperczyk-no
force-pushed
the
merge_factory_data_scripts
branch
2 times, most recently
from
April 8, 2024 06:33
ee8ac04
to
9c4a700
Compare
ArekBalysNordic
approved these changes
Apr 8, 2024
kkasperczyk-no
force-pushed
the
merge_factory_data_scripts
branch
2 times, most recently
from
April 8, 2024 06:44
320f9a6
to
7993bd0
Compare
markaj-nordic
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Only some minors found.
kkasperczyk-no
force-pushed
the
merge_factory_data_scripts
branch
from
April 8, 2024 08:38
7993bd0
to
1394ea2
Compare
The factory_data.hex file is not generated as an intermediate product of factory generation process. In result, factory generation works only if merging with firmware is used or scripts are manually invoked. Added optional --size and --offset arguments to generate_nrfconnect_chip_factory_data.py script that results in calling nrfconnect_generate_partition.py internally. It solves an issue and additionally simplifies manual generation process (if selected).
kkasperczyk-no
force-pushed
the
merge_factory_data_scripts
branch
from
April 8, 2024 09:24
1394ea2
to
f20ecde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The factory_data.hex file is not generated as an intermediate product of factory generation process. In result, factory generation works only if merging with firmware is used or scripts are manually invoked.
Added optional --size and --offset arguments to
generate_nrfconnect_chip_factory_data.py script that results in calling nrfconnect_generate_partition.py internally. It solves an issue and additionally simplifies manual generation process (if selected).