[nrf noup] Workaround for PSA P256Keypair Generate #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArekBalysNordic
requested review from
LuDuda,
kkasperczyk-no,
Damian-Nordic and
markaj-nordic
Damian-Nordic
approved these changes
Apr 24, 2024
| @@ -63,6 +65,10 @@ CHIP_ERROR PSAOperationalKeystore::PersistentP256Keypair::Generate() | |||
|
|
|||
| Destroy(); | |||
|
|
|||
| #ifdef CONFIG_NET_L2_OPENTHREAD | |||
| chip::DeviceLayer::ThreadStackMgr().LockThreadStack(); | |||
There was a problem hiding this comment.
Worth adding a comment that it's a temporary hack.
This is workaround to ensure thread-safety for P256Keypair generation when both Matter and Openthread threads want to generate keys. This workaround can be removed once the PSA core supports thread-safety.
ArekBalysNordic
force-pushed
the
nrf54l15_cr_workaround
branch
from
f782e80
to
327a4d3
Compare
markaj-nordic
approved these changes
Apr 24, 2024
|
Closing, because it will be repaired in the Crypto core. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround to ensure thread-safety for P256Keypair generation when both Matter and Openthread threads want to generate keys.