Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrf toup][nrfconnect] Removed defaults for child images #449

Conversation

kkasperczyk-no
Copy link
Contributor

Due to the sysbuild integration and child images deprecation the default configuration for child images has been removed.

Due to the sysbuild integration and child images deprecation
the default configuration for child images has been removed.
Copy link
Contributor

@ArekBalysNordic ArekBalysNordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess [nrf toup] will not work for this separate commit since samples in upstream are not ready for that :) Maybe we should point it out somehow?

@kkasperczyk-no
Copy link
Contributor Author

I guess [nrf toup] will not work for this separate commit since samples in upstream are not ready for that :) Maybe we should point it out somehow?

Yeah I know. I didn't want to modify the child_images content, because probably we will contribute this commit with the NCS 2.7.0 and start using sysbuild in the upstream, so it's pointless. I thought we will introduce sysbuild support to the examples with the next NCS upmerge and this commit will be part of it. What do you think about it?

@ArekBalysNordic
Copy link
Contributor

I guess [nrf toup] will not work for this separate commit since samples in upstream are not ready for that :) Maybe we should point it out somehow?

Yeah I know. I didn't want to modify the child_images content, because probably we will contribute this commit with the NCS 2.7.0 and start using sysbuild in the upstream, so it's pointless. I thought we will introduce sysbuild support to the examples with the next NCS upmerge and this commit will be part of it. What do you think about it?

OK, let's do it in this way :)

@kkasperczyk-no kkasperczyk-no merged commit 0ae05f2 into nrfconnect:master Jun 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants