[nrf noup] Fix "west zap-gui" on Windows #454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use zap-cli.exe instead of zap.exe to determine the current ZAP version. The latter seems to generate unexpected output on Windows. Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
ArekBalysNordic
approved these changes
Jun 17, 2024
LuDuda
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
However.. this does not seem to be an issue on my set-up. Wondering if we should proceed with it to NCS 2.7.0 release - @Damian-Nordic ?
|
I think I'll close the PR if this doesn't help when using nRF Terminal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use zap-cli.exe instead of zap.exe to determine the current ZAP version. The latter seems to generate unexpected output on Windows.