Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

[nrf noup] wpa_supplicant: Remove non-output status #130

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

kapbh
Copy link
Contributor

@kapbh kapbh commented Nov 7, 2023

There is "OK"/"FAIL" status multipal times during
wifi connect. Skip for wifi management commands.

wpa_supplicant/wpa_cli_zephyr.c Outdated Show resolved Hide resolved
wpa_supplicant/wpa_cli_zephyr.c Outdated Show resolved Hide resolved
@kapbh kapbh force-pushed the remove_ok branch 4 times, most recently from 6f2f0bd to 4688e5b Compare November 8, 2023 08:29
@krish2718
Copy link
Collaborator

Also the commit log is not proper, for nrf noup it should refers to the original commit like below, see

[nrf noup] area: incremental fix

fixup! [nrf noup] area: original commit log

wpa_supplicant/wpa_cli_zephyr.c Outdated Show resolved Hide resolved
@sachinthegreen
Copy link
Collaborator

Please change this PR to a draft till the final solution is implemented.

@kapbh kapbh marked this pull request as draft December 11, 2023 09:03
@kapbh kapbh marked this pull request as ready for review December 19, 2023 10:40
@kapbh kapbh requested a review from krish2718 December 19, 2023 10:40
wpa_supplicant/wpa_cli_cmds.c Show resolved Hide resolved
wpa_supplicant/wpa_cli_zephyr.c Outdated Show resolved Hide resolved
wpa_supplicant/wpa_cli_zephyr.c Outdated Show resolved Hide resolved
wpa_supplicant/wpa_cli_cmds.c Outdated Show resolved Hide resolved
@jukkar
Copy link
Contributor

jukkar commented Dec 19, 2023

Do we really need this? I mean that the OK/FAIL will show the status of the issued command which is kind of useful information.
Annoyingly the FAIL/OK print extra \n which looks bad, so I am proposing this change in upstream that skips the extra newline here zephyrproject-rtos/hostap@c3dddd3

@krish2718
Copy link
Collaborator

Do we really need this? I mean that the OK/FAIL will show the status of the issued command which is kind of useful information. Annoyingly the FAIL/OK print extra \n which looks bad, so I am proposing this change in upstream that skips the extra newline here zephyrproject-rtos/hostap@c3dddd3

Yes, we had multiple tickets from customers about the random OK/FAIL without any context. These are only useful in interactive environment where a single command is types in and you get a response OK/FAIL with newlines. But in non-interactive environment these are useless and the error checking can be handled programatically.

fixup! [nrf noup] zephyr: Add support for WPA CLI zephyr

Chnage the direct function call from wpa_ctrl_command
to wpa_cli_cmd. This change is require to prepare for
new interactive API.

Signed-off-by: Kapil Bhatt <kapil.bhatt@nordicsemi.no>
fixup! [nrf noup] zephyr: Add support for WPA CLI zephyr

There is "OK/FAIL" status multipal times during
wifi commands. Make new interactive api for wap_cli
commands which prints "OK/FAIL". It will avoid prints
for wifi commands.

Signed-off-by: Kapil Bhatt <kapil.bhatt@nordicsemi.no>
@rlubos rlubos merged commit 42c77f9 into nrfconnect:main Dec 21, 2023
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants