This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Fix socket resp handling #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixup! [nrf noup] zephyr: Add support for WPA CLI zephyr As length is output of number of bytes received from socket we should handle zero bytes as well, since we use stream sockets this happens when the other end is shutdown. Without this fix in a resource constrained envrionment len can become zero and as its unsigned it overflows causing a crash. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
fixup! [nrf noup] zephyr: Add support for WPA CLI zephyr sscanf is used on the response buffer which expects NULL terminated buffers. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
requested review from
jukkar,
rado17,
sachinthegreen and
rlubos
as code owners
krish2718
force-pushed
the
fix_socket_resp_handling
branch
from
fb685d1
to
511b2af
Compare
kapbh
approved these changes
Nov 9, 2023
jukkar
approved these changes
Nov 9, 2023
fixup! [nrf noup] zephyr: Add support for WPA CLI zephyr Print only non-empty responses. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
force-pushed
the
fix_socket_resp_handling
branch
from
511b2af
to
951f188
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.