This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
[nrf noup] zephyr: Fix argument count for wpa_cli #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krish2718
requested review from
jukkar,
rado17,
sachinthegreen and
rlubos
as code owners
jukkar
approved these changes
Nov 23, 2023
fixup! [nrf noup] zephyr: Add support for WPA CLI zephyr For wpa_cli command the argument count was off by 1 as we remove the command itself and pass rest of the arguments to the handler. This still works fine for most, but for "interface_add" it relies of argument count for preparing command over control interface and ends up setting a L2 bridge interface which is invalid and hence causing issues. Fixes SHEL-2196. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
force-pushed
the
fix_arg_count
branch
from
ccfecc7
to
17e9be1
Compare
rado17
approved these changes
Nov 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixup! [nrf noup] zephyr: Add support for WPA CLI zephyr
For wpa_cli command the argument count was off by 1 as we remove the command itself and pass rest of the arguments to the handler. This still works fine for most, but for "interface_add" it relies of argument count for preparing command over control interface and ends up setting a L2 bridge interface which is invalid and hence causing issues.
Fixes SHEL-2196.