This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Fix WPA supplicant internal events processing #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixup! [nrf noup] Monitor supplicant state and inform applications Even though the payload is of fixed size, move it to the end for easier parsing. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
fixup! [nrf noup] Monitor supplicant state and inform applications Incoming message has a pre-defined structure and isn't a arbitrary blob, so, use the structure to parse properly. This was working earlier as the payload was in the beginning of the structure, but if we ever end up with a longer message then we would see issues. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
fixup! [nrf noup] Monitor supplicant state and inform applications The incoming message is payload + length, so, need to include size of the "length" field. Fixes SHEL-2250. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
fixup! [nrf noup] Monitor supplicant state and inform applications Sender is sending the entire structure, and receiving one byte lesser results in two receive calls per-message, this screws up the message parsing. Fixes SHEL-2250. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
requested review from
jukkar,
rado17,
sachinthegreen and
rlubos
as code owners
rado17
approved these changes
Dec 6, 2023
jukkar
approved these changes
Dec 7, 2023
sachinthegreen
approved these changes
Dec 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.