This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Fix SAP restart #146
Merged
Fix SAP restart #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixup! [nrf noup] zephyr: Implement basic AP ops When AP is restart (enable, disable, enable), then the beacon set flag isn't cleared as stop_ap isn't called in the normal path, it's only for the AP control interface. But during AP disable, deinit_ap OP is called, but the flag wasn't cleared in that OP causing AP to start successfully, but without calling start_ap FMAC API. Fixes SHEL-2370. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
requested review from
jukkar,
rado17,
sachinthegreen and
rlubos
as code owners
sachinthegreen
suggested changes
Jan 18, 2024
fixup! [nrf noup] zephyr: Implement basic AP ops This way we can handle intermittent failures instead of locking up the system. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
fixup! [nrf noup] ci: Add compliance test This isn't maintained for this project. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
force-pushed
the
fix_ap_restart
branch
from
13183e4
to
0f482af
Compare
rado17
approved these changes
Jan 18, 2024
sachinthegreen
approved these changes
Jan 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.