Skip to content

Commit

Permalink
drivers: wifi: Rename PS data retrieval options
Browse files Browse the repository at this point in the history
The logic in the firmware is about exiting power save, the data
retrieval itself is pretty standardized.

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
  • Loading branch information
krish2718 committed Aug 29, 2024
1 parent 7fb91f0 commit 25d58b4
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 18 deletions.
29 changes: 14 additions & 15 deletions drivers/wifi/nrf700x/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -404,26 +404,25 @@ config NRF_WIFI_AP_DEAD_DETECT_TIMEOUT
The number of seconds after which AP is declared dead if no beacons
are received from the AP. Used to detect AP silently going down e.g., power off.

choice NRF_WIFI_PS_DATA_RETRIEVAL_MECHANISM
prompt "Power save data retrieval mechanism"
default NRF_WIFI_PS_POLL_BASED_RETRIEVAL
choice NRF_WIFI_PS_EXIT_STRATEGY
prompt "Power save exit strategy"
default NRF_WIFI_PS_INT_PS
help
Select the mechanism to retrieve buffered data from AP.
Select the power save exit strategy to retrieve buffered data from AP.

config NRF_WIFI_PS_POLL_BASED_RETRIEVAL
bool "PS-Poll frame based mechanism to retrieve buffered data from AP"
config NRF_WIFI_PS_EXIT_EVERY_TIM
bool "Exit power save every time to retrieve buffered data from AP"
help
When AP notifies about availability of buffered data, the STA stays in power save
and retrieves the frames one-by-one, this conserved more power but adds latency
to the traffic. Ideal for minimum number of frames.
Exit power save every time to retrieve buffered data from AP. Entering back to
power save mode might take some time and power.

config NRF_WIFI_QOS_NULL_BASED_RETRIEVAL
bool "QoS null frame based mechanism to retrieve buffered data from AP"
config NRF_WIFI_PS_INT_PS
bool "Exit power save based on an intelligent algorithm"
help
When AP notifies about availability of buffered data, the STA comes out of
power save and then AP can deliver all buffered frames without any additional
overhead or latency, but STA enters power save after a delay costing more power
depending on the delay. Ideal for heavy buffered traffic.
Exit power save based on an intelligent algorithm to retrieve buffered data from AP.
The algorithm tracks the buffered data at the AP and then dynamically decides
whether to stay in PS (for lower amount of buffered data) or exit PS (for higher
amount of buffered data).

endchoice

Expand Down
6 changes: 3 additions & 3 deletions drivers/wifi/nrf700x/osal/fw_if/umac_if/src/cmd.c
Original file line number Diff line number Diff line change
Expand Up @@ -213,11 +213,11 @@ enum nrf_wifi_status umac_cmd_init(struct nrf_wifi_fmac_dev_ctx *fmac_dev_ctx,
umac_cmd_data->disable_beamforming = 1;
}

#if defined(CONFIG_NRF_WIFI_QOS_NULL_BASED_RETRIEVAL)
umac_cmd_data->ps_exit_strategy = CUSTOM;
#if defined(CONFIG_NRF_WIFI_PS_INT_PS)
umac_cmd_data->ps_exit_strategy = INT_PS;
#else
umac_cmd_data->ps_exit_strategy = EVERY_TIM;
#endif /* CONFIG_NRF_WIFI_QOS_NULL_BASED_RETRIEVAL */
#endif /* CONFIG_NRF_WIFI_PS_INT_PS */

status = nrf_wifi_hal_ctrl_cmd_send(fmac_dev_ctx->hal_dev_ctx,
umac_cmd,
Expand Down

0 comments on commit 25d58b4

Please sign in to comment.