Skip to content

Commit

Permalink
samples: Fix handling of combo build for Wi-Fi radio test
Browse files Browse the repository at this point in the history
Wi-Fi radio test combo build is disabled by default and if enabled has
to pull in the peripheral radio test child image to CPUNET for nRF5340.

This is controlled by used of CPUNET configuration, but due to the
mismatch in choosing different Kconfig options RPMSG child image vs.
Peripheral radio test image, the partition manager is enabled because
radio test sample is enabled, but no child image is enabled as CPUNET is
disabled.

Fix this by using the newly add macro that takes care of all
dependencies.

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
  • Loading branch information
krish2718 authored and rlubos committed Jul 7, 2023
1 parent 779ebd1 commit bb6cf87
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions samples/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ config NCS_SAMPLE_EMPTY_APP_CORE_CHILD_IMAGE

config NCS_INCLUDE_RPMSG_CHILD_IMAGE
bool "Include RPMsg sample on netcore"
depends on SOC_NRF5340_CPUAPP && (BT_RPMSG || NRF_802154_SER_HOST || BT_RPC || NRF700X_RADIO_TEST)
depends on SOC_NRF5340_CPUAPP && (BT_RPMSG || NRF_802154_SER_HOST || BT_RPC || NRF700X_RADIO_TEST_COMBO)
select PARTITION_MANAGER_ENABLED
default y if BT_RPMSG || NRF_802154_SER_HOST || BT_RPC || NRF700X_RADIO_TEST
default y if BT_RPMSG || NRF_802154_SER_HOST || BT_RPC || NRF700X_RADIO_TEST_COMBO
help
Enabling this setting will include a network stack to run on the
network core and communicate over RPMsg with the application core.
Expand Down Expand Up @@ -65,35 +65,35 @@ if NCS_INCLUDE_RPMSG_CHILD_IMAGE

config NCS_SAMPLE_MULTIPROTOCOL_RPMSG_CHILD_IMAGE
bool
depends on BT_RPMSG && NRF_802154_SER_HOST && !BT_RPC && !NRF700X_RADIO_TEST
depends on BT_RPMSG && NRF_802154_SER_HOST && !BT_RPC && !NRF700X_RADIO_TEST_COMBO
default y
help
multiprotocol_rpmsg sample as a child image (network core).

config NCS_SAMPLE_HCI_RPMSG_CHILD_IMAGE
bool
depends on BT_RPMSG && !NRF_802154_SER_HOST && !BT_RPC && !NRF700X_RADIO_TEST
depends on BT_RPMSG && !NRF_802154_SER_HOST && !BT_RPC && !NRF700X_RADIO_TEST_COMBO
default y
help
hci_rpmsg sample as a child image (network core).

config NCS_SAMPLE_802154_RPMSG_CHILD_IMAGE
bool
depends on NRF_802154_SER_HOST && !BT_RPMSG && !BT_RPC && !NRF700X_RADIO_TEST
depends on NRF_802154_SER_HOST && !BT_RPMSG && !BT_RPC && !NRF700X_RADIO_TEST_COMBO
default y
help
802154_rpmsg sample as a child image (network core).

config NCS_SAMPLE_RPC_HOST_CHILD_IMAGE
bool
depends on BT_RPC && !NRF700X_RADIO_TEST
depends on BT_RPC && !NRF700X_RADIO_TEST_COMBO
default y
help
rpc_host sample as a child image (network core).

config NCS_SAMPLE_PERIPHERAL_RADIO_TEST_CHILD_IMAGE
bool "Add peripheral radio_test sample as a child image"
depends on NRF700X_RADIO_TEST && BOARD_ENABLE_CPUNET
depends on NRF700X_RADIO_TEST_COMBO
default y
select PARTITION_MANAGER_ENABLED
help
Expand Down

0 comments on commit bb6cf87

Please sign in to comment.