Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: nrf_modem_lib: lte_connectivity: Add CEREG listening #11424

Merged
merged 1 commit into from
Jul 7, 2023
Merged

lib: nrf_modem_lib: lte_connectivity: Add CEREG listening #11424

merged 1 commit into from
Jul 7, 2023

Conversation

glarsennordic
Copy link
Contributor

lte_connectivity now monitors CEREG notifications to more accurately determine whether connectivity is available.

Includes a configurable timeout controlling how long the device can be without a serving cell before serving cell is considered lost.

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jun 3, 2023
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@glarsennordic
Copy link
Contributor Author

Note for future self: Modify commit to include ticket ID

@trantanen trantanen requested a review from jhirsi June 5, 2023 09:07
@glarsennordic
Copy link
Contributor Author

glarsennordic commented Jun 5, 2023 •
edited
Loading

This PR is marked as a draft because it is missing updates to unit tests, but a review now just to confirm that this approach is valid / makes sense would be immensely useful

trantanen
trantanen reviewed Jun 8, 2023
View reviewed changes
Copy link
Contributor

@trantanen trantanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few questions at this point

lib/nrf_modem_lib/lte_connectivity/lte_connectivity.c Show resolved Hide resolved
lib/nrf_modem_lib/lte_connectivity/lte_connectivity.c Outdated Show resolved Hide resolved
@glarsennordic glarsennordic mentioned this pull request Jun 13, 2023
Merged
@glarsennordic glarsennordic force-pushed the IRIS6358 branch 2 times, most recently from f1ee421 to 40db677 Compare June 14, 2023 21:10
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jun 14, 2023 •
edited
Loading

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-nrf-iot_lwm2m X
test-fw-nrfconnect-nrf-iot_mosh X
test-fw-nrfconnect-nrf-iot_samples X
test-fw-nrfconnect-nrf-iot_serial_lte_modem X
test-fw-nrfconnect-nrf-iot_zephyr_lwm2m X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

peknis
peknis requested changes Jun 16, 2023
View reviewed changes
lib/nrf_modem_lib/lte_connectivity/lte_connectivity.h Outdated Show resolved Hide resolved
lib/nrf_modem_lib/lte_connectivity/lte_connectivity.h Outdated Show resolved Hide resolved
lib/nrf_modem_lib/lte_connectivity/lte_connectivity.h Outdated Show resolved Hide resolved
lib/nrf_modem_lib/lte_connectivity/lte_connectivity.h Outdated Show resolved Hide resolved
@glarsennordic glarsennordic force-pushed the IRIS6358 branch 3 times, most recently from 9ed4147 to 37382e8 Compare June 22, 2023 00:15
@glarsennordic glarsennordic marked this pull request as ready for review June 22, 2023 00:15
@glarsennordic glarsennordic mentioned this pull request Jun 22, 2023
Closed
plskeggs
plskeggs approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@plskeggs plskeggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan to update the changelog?

@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jun 23, 2023
@glarsennordic
Copy link
Contributor Author

Whoops, thank you for the reminder, I had forgotten! @plskeggs

simensrostad
simensrostad reviewed Jun 29, 2023
View reviewed changes
Copy link
Contributor

@simensrostad simensrostad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the changes looks good! Thanks for taking the time to do this.

tests/lib/nrf_modem_lib/lte_connectivity/src/lte_connectivity_test.c Outdated Show resolved Hide resolved
tests/lib/nrf_modem_lib/lte_connectivity/src/lte_connectivity_test.c Show resolved Hide resolved
tests/lib/nrf_modem_lib/lte_connectivity/src/lte_connectivity_test.c Outdated Show resolved Hide resolved
tests/lib/nrf_modem_lib/lte_connectivity/src/lte_connectivity_test.c Outdated Show resolved Hide resolved
tests/lib/nrf_modem_lib/lte_connectivity/src/lte_connectivity_test.c Outdated Show resolved Hide resolved
lib/nrf_modem_lib/lte_connectivity/lte_connectivity.c Show resolved Hide resolved
lib/nrf_modem_lib/lte_connectivity/lte_connectivity.c Outdated Show resolved Hide resolved
lib/nrf_modem_lib/lte_connectivity/lte_connectivity.c Outdated Show resolved Hide resolved
lib/nrf_modem_lib/lte_connectivity/lte_connectivity.c Outdated Show resolved Hide resolved
lib/nrf_modem_lib/lte_connectivity/lte_connectivity.c Show resolved Hide resolved
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jul 1, 2023
@glarsennordic glarsennordic force-pushed the IRIS6358 branch 2 times, most recently from 41bde84 to ba8269f Compare July 1, 2023 00:27
@glarsennordic
lib: nrf_modem_lib: lte_connectivity: Add CEREG listening
6f9322e 
lte_connectivity now monitors CEREG notifications to more accurately
determine whether connectivity is available.

Signed-off-by: Georges Oates_Larsen <georges.larsen@nordicsemi.no>
@nordicjm nordicjm merged commit 5397052 into nrfconnect:main Jul 7, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlubos rlubos rlubos left review comments

@plskeggs plskeggs plskeggs approved these changes

@tokangas tokangas tokangas approved these changes

@jtguggedal jtguggedal jtguggedal approved these changes

@jhirsi jhirsi jhirsi approved these changes

@simensrostad simensrostad simensrostad approved these changes

@peknis peknis peknis approved these changes

@stig-bjorlykke stig-bjorlykke Awaiting requested review from stig-bjorlykke

@lemrey lemrey Awaiting requested review from lemrey lemrey is a code owner

@MirkoCovizzi MirkoCovizzi Awaiting requested review from MirkoCovizzi MirkoCovizzi is a code owner

@trantanen trantanen Awaiting requested review from trantanen

@carlescufi carlescufi Awaiting requested review from carlescufi

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.