samples: cellular: rename from nrf9160 #11500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eivindj-nordic
requested review from
trantanen,
tokangas,
gregersrygg,
balaji-nordic,
SeppoTakalo,
juhaylinen,
plskeggs,
jayteemo,
glarsennordic,
stig-bjorlykke,
jhirsi,
rlubos,
jarlamsa,
jheiskan81,
jtguggedal,
simensrostad,
coderbyheart,
lemrey,
a team,
carlescufi and
gmarull
as code owners
github-actions
bot
added
the
doc-required
eivindj-nordic
force-pushed
the
22125_modem_sample_folder
branch
2 times, most recently
from
12ddf3c
to
685f92b
Compare
|
Should these be renamed at the same time or what's the plan? |
Yes, they should be renamed as well :) |
eivindj-nordic
force-pushed
the
22125_modem_sample_folder
branch
2 times, most recently
from
421f5f9
to
7f6788b
Compare
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
eivindj-nordic
force-pushed
the
22125_modem_sample_folder
branch
from
acab6d1
to
f160f72
Compare
|
Yes, CI need an update in multiple domains, will try to track it on Jira NCSDK-22125 (internal) @divipillai to add documentation update. |
eivindj-nordic
force-pushed
the
22125_modem_sample_folder
branch
2 times, most recently
from
2cc3483
to
1ae4749
Compare
eivindj-nordic
force-pushed
the
22125_modem_sample_folder
branch
3 times, most recently
from
f989d34
to
d8e2c04
Compare
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
plskeggs
approved these changes
Jun 22, 2023
shanthanordic
approved these changes
Jun 27, 2023
eivindj-nordic
force-pushed
the
22125_modem_sample_folder
branch
from
d8e2c04
to
4ff4ec4
Compare
divipillai
approved these changes
Jun 27, 2023
| nRF9160: Modem trace external flash backend | ||
| ########################################### | ||
| Cellular: Modem trace external flash backend | ||
| ############################################ |
There was a problem hiding this comment.
In line no: 71, file name needs to be renamed as: :file:samples/cellular/modem_trace_flash
eivindj-nordic
force-pushed
the
22125_modem_sample_folder
branch
3 times, most recently
from
f72ba10
to
a63e492
Compare
github-actions
bot
added
the
changelog-entry-required
eivindj-nordic
force-pushed
the
22125_modem_sample_folder
branch
9 times, most recently
from
de95baa
to
e311597
Compare
Rename nrf9160 samples folder to cellular Co-authored-by: divya pillai <divya.pillai@nordicsemi.no> Signed-off-by: Eivind Jølsgard <eivind.jolsgard@nordicsemi.no>
eivindj-nordic
force-pushed
the
22125_modem_sample_folder
branch
from
e311597
to
331a70d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename nrf9160 samples folder to cellular
test-sdk-nrf: sdk-nrf_PR_11500