lib: location: Add support for GCI cell #11549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
trantanen
commented
Jun 20, 2023
trantanen
commented
Jun 20, 2023
github-actions
bot
added
the
doc-required
github-actions
bot
removed
the
changelog-entry-required
tokangas
reviewed
Jun 20, 2023
peknis
requested changes
Jun 21, 2023
trantanen
commented
Jun 21, 2023
tokangas
reviewed
Jun 22, 2023
jhirsi
reviewed
Jun 22, 2023
jhirsi
reviewed
Jun 22, 2023
trantanen
force-pushed
the
loclib_gci
branch
3 times, most recently
from
6d6c3aa
to
1f69782
Compare
peknis
approved these changes
Jun 26, 2023
tokangas
approved these changes
Jun 26, 2023
jhirsi
approved these changes
Jun 26, 2023
Support added for GCI (surrounding) cells in cellular positioning. NCELLMEAS=2 is used by default. If we don’t find X cells, do NCELLMEAS=4,Y, where Y=5-X. X is requested cell count and run-time configurable through cell_count member of struct location_cellular_config and build time configurable through CONFIG_LOCATION_REQUEST_DEFAULT_CELLULAR_CELL_COUNT. Cellular timeout will change to apply only for NCELLMEAS operation ignoring the cloud communication. Same change for Wi-Fi timeout. GCI search can be disabled completely by setting CONFIG_LOCATION_REQUEST_DEFAULT_CELLULAR_CELL_COUNT=0 Jira: NCSDK-21877 Signed-off-by: Tommi Rantanen <tommi.rantanen@nordicsemi.no>
We need to protect execution of AT%NCELLMEAS with a semaphore. Otherwise a client that calls new lte_lc_neighbor_cell_measurement() right after receiving LTE_LC_EVT_NEIGHBOR_CELL_MEAS event, may get -EINPROGRESS error code even though AT%NCELLMEAS notification had been received. Signed-off-by: Tommi Rantanen <tommi.rantanen@nordicsemi.no>
github-actions
bot
added
the
changelog-entry-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support added for GCI (surrounding) cells in cellular positioning.
NCELLMEAS=2is used by default. If we don’t find X cells, doNCELLMEAS=4,Y, whereY=5-X.X is requested cell count and run-time configurable through
cell_countmember ofstruct location_cellular_configand build time configurable throughCONFIG_LOCATION_REQUEST_DEFAULT_CELLULAR_CELL_COUNT.Cellular timeout will change to apply only for NCELLMEAS operation ignoring the cloud communication. Same change for Wi-Fi timeout.
GCI search can be disabled completely by setting
CONFIG_LOCATION_REQUEST_DEFAULT_CELLULAR_CELL_COUNT=0Jira: NCSDK-21877