manifest: bootloader: mcuboot: Fix wrong use of if defined #11574
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog-entry-required
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
osaether
force-pushed
the
fix_if_defined_bug
branch
2 times, most recently
from
0cca482
to
a485cf2
Compare
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
test-ci-nrfconnect-boot-fw-update: added because there was no .github/test-spec.yml in 'mcuboot' Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
osaether
force-pushed
the
fix_if_defined_bug
branch
2 times, most recently
from
81de263
to
ddd6130
Compare
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
osaether
force-pushed
the
fix_if_defined_bug
branch
5 times, most recently
from
f5a2f46
to
942a436
Compare
osaether
force-pushed
the
fix_if_defined_bug
branch
5 times, most recently
from
3dd90b2
to
4a4cdc6
Compare
osaether
requested review from
hakonfam,
oyvindronningstad and
sigvartmh
and removed request for
hakonfam
osaether
force-pushed
the
fix_if_defined_bug
branch
from
4a4cdc6
to
e0b1f8c
Compare
sigvartmh
approved these changes
Jul 6, 2023
oyvindronningstad
approved these changes
Jul 6, 2023
osaether
force-pushed
the
fix_if_defined_bug
branch
4 times, most recently
from
ff7dcc1
to
71fbbc5
Compare
The file nrf_cleanup.c has "#if defined(USE_PARTITION_MANAGER)" Which is true even if USE_PARTITION_MANAGER=n. This must be changed to "#if USE_PARTITION_MANAGER" for correct behaviour. Ref: NCSIDB-987 Signed-off-by: Ole Sæther <ole.saether@nordicsemi.no>
osaether
force-pushed
the
fix_if_defined_bug
branch
from
71fbbc5
to
69a607a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file nrf_cleanup.c has
#if defined(USE_PARTITION_MANAGER)
Which is true even if USE_PARTITION_MANAGER=n.
This must be changed to "#if USE_PARTITION_MANAGER" for correct behaviour.
Ref: NCSIDB-987