Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various: Enclose string if checks in quotes #11617

Merged
merged 1 commit into from
Jul 26, 2023

Commits on Jul 25, 2023

  1. various: Enclose string if checks in quotes

    Fixes possible issues whereby string variables are checked
    without being properly encased in quote marks. This is needed
    because unescaped variables will be treated as variable names,
    then errors will be emitted when they are dereferenced and those
    variables do not exist. This fixes issue like the following:
    
           *************************
           * Running CMake for ncp *
           *************************
        CMake Error at CMakeLists.txt:10 (if):
          if given arguments:
            "STREQUAL" "nrf52840dongle_nrf52840"
          Unknown arguments specified
    
    Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
    nordicjm committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    8b75c62 View commit details
    Browse the repository at this point in the history