samples: Bluetooth: df: Add postfix in sample.yaml to remove duplicates #11630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppryga-nordic
requested review from
alwa-nordic,
carlescufi and
KAGA164
as code owners
github-actions
bot
added
the
changelog-entry-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
PerMac
approved these changes
Jun 29, 2023
There is a twister run issue caused by duplication of direction finding sample names in sdk-nrf and Zephyr repositories. To remove the problem names used in sample.yaml in sdk-nrf are extended with postfil `_nrf`. That makes them unique in scope of these repositories. Signed-off-by: Piotr Pryga <piotr.pryga@nordicsemi.no>
ppryga-nordic
force-pushed
the
github-change-sample-yml-for-df-samples-to-remove-duplicates-with-zephyr
branch
from
c390763
to
565042a
Compare
alwa-nordic
approved these changes
Jun 30, 2023
KAGA164
approved these changes
Jun 30, 2023
|
Paths in downstream apps plan are updated. This PR is checked in downstream and is green: https://jenkins-ncs.nordicsemi.no/blue/organizations/jenkins/latest%2Ftest-fw-nrfconnect-apps/detail/pipeline%2Fupdate_df_sample_paths/3/pipeline PR can be merged with unstable apps plan. I'll merge downstream PR with update asap this one is merged |
|
@jumi-nordic Please merge whatever you need to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a twister run issue caused by duplication of direction finding sample names in sdk-nrf and Zephyr repositories. To remove the problem names used in sample.yaml in sdk-nrf are extended with postfix
_nrf. That makes them unique in scope of these repositories.Signed-off-by: Piotr Pryga piotr.pryga@nordicsemi.no