treewide: Remove unnecessary modem dependencies related to MMSS #11632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
glarsennordic
force-pushed
the
IRIS-4658
branch
2 times, most recently
from
79c372b
to
c415ee2
Compare
glarsennordic
requested review from
plskeggs,
jayteemo,
trantanen,
jhirsi and
tokangas
as code owners
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
glarsennordic
force-pushed
the
IRIS-4658
branch
2 times, most recently
from
9cefc82
to
a05e798
Compare
jayteemo
reviewed
Jun 27, 2023
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
tokangas
reviewed
Jun 28, 2023
jayteemo
reviewed
Jun 28, 2023
glarsennordic
force-pushed
the
IRIS-4658
branch
2 times, most recently
from
52b9f56
to
dba5195
Compare
glarsennordic
commented
Jun 28, 2023
| #include <zephyr/net/socket.h> | ||
| #include <net/nrf_cloud.h> | ||
| #include <net/nrf_cloud_codec.h> | ||
| #include <date_time.h> | ||
| #include <zephyr/logging/log.h> | ||
| #include <modem/nrf_modem_lib.h> |
There was a problem hiding this comment.
Keeping #include <modem/nrf_modem_lib.h> for now until #11519 merges
glarsennordic
force-pushed
the
IRIS-4658
branch
2 times, most recently
from
88afa7d
to
3cfec20
Compare
jayteemo
approved these changes
Jun 28, 2023
jhirsi
approved these changes
Jun 29, 2023
tokangas
approved these changes
Jun 29, 2023
glarsennordic
force-pushed
the
IRIS-4658
branch
2 times, most recently
from
16800fb
to
39d63bf
Compare
Remove various unnecessary modem dependencies that prevent building the MQTT Multi Service Sample for Wi-Fi-only targets. IRIS-6344 IRIS-5812 Signed-off-by: Georges Oates_Larsen <georges.larsen@nordicsemi.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove various unnecessary modem dependencies that prevent building the MQTT Multi Service Sample for Wi-Fi-only targets.
IRIS-6344
IRIS-5812