Improve driver debug #11647
Merged
Improve driver debug #11647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krish2718
requested review from
sachinthegreen,
rado17,
rlubos,
carlescufi and
tejlmand
as code owners
github-actions
bot
added
changelog-entry-required
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
test-sdk-wifi: added because there was no .github/test-spec.yml in 'hostap' Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
VivekUppunda
approved these changes
Jun 29, 2023
rado17
approved these changes
Jun 29, 2023
Most of the times the driver debugging is needed only at a high level, and having a single level for entire driver makes the logs clumsier esp. low level code is excited for all and has good debugs, so, add a separate logging module for low-level stuff. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
* Unhandled event should be an error * Add debug logs for commands and events Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
Fixes memory leak when querying connection info from the driver. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
force-pushed
the
improve_driver_debug
branch
from
b2a9d43
to
e9808f9
Compare
sachinthegreen
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.