Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wifi: Radio test combo fixes #11683

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Conversation

krish2718
Copy link
Contributor

Fix and cleanup radio test combo

@krish2718 krish2718 requested review from bama-nordic and a team as code owners July 3, 2023 15:42
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jul 3, 2023
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jul 3, 2023

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-sdk-wifi X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@krish2718 krish2718 force-pushed the radio_test_combo_fixes branch 2 times, most recently from 3fff02c to f9b5678 Compare July 6, 2023 11:20
Add a Kconfig option to choose to build for a combo build for nRF700x
radio test. As we intend use the define in this file, it cannot be
defined under samples/wifi/radio_test.

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
Wi-Fi radio test combo build is disabled by default and if enabled has
to pull in the peripheral radio test child image to CPUNET for nRF5340.

This is controlled by used of CPUNET configuration, but due to the
mismatch in choosing different Kconfig options RPMSG child image vs.
Peripheral radio test image, the partition manager is enabled because
radio test sample is enabled, but no child image is enabled as CPUNET is
disabled.

Fix this by using the newly add macro that takes care of all
dependencies.

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
Use newly introduced combo build.

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
@rlubos rlubos merged commit 6258817 into nrfconnect:main Jul 7, 2023
@krish2718 krish2718 deleted the radio_test_combo_fixes branch December 14, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants