bluetooth: fast_pair: Delete "reset" flag instead of storing false #11686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog-entry-required
MarekPieta
removed
the
changelog-entry-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
alstrzebonski
approved these changes
Jul 4, 2023
MarekPieta
force-pushed
the
fp_factory_reset_cleanup
branch
from
55f330d
to
ffc3f04
Compare
github-actions
bot
added
the
changelog-entry-required
MarekPieta
removed
the
changelog-entry-required
mkapala-nordic
approved these changes
Jul 4, 2023
divipillai
approved these changes
Jul 4, 2023
Change deletes Fast Pair storage manager's "reset" flag instead of storing it as false to ensure no data is left in settings after a successful factory reset operation. Jira: NCSDK-20219 Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no>
MarekPieta
force-pushed
the
fp_factory_reset_cleanup
branch
from
ffc3f04
to
c81ef61
Compare
github-actions
bot
added
the
changelog-entry-required
kapi-no
approved these changes
Jul 4, 2023
MarekPieta
removed
the
changelog-entry-required
MarekPieta
force-pushed
the
fp_factory_reset_cleanup
branch
from
c81ef61
to
c55fe20
Compare
github-actions
bot
added
the
changelog-entry-required
MarekPieta
removed
the
changelog-entry-required
Change ensures that reset in progress flag is deleted during the Fast Pair factory reset operation. Jira: NCSDK-20219 Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no>
MarekPieta
force-pushed
the
fp_factory_reset_cleanup
branch
from
3e2bc38
to
123882d
Compare
github-actions
bot
added
the
changelog-entry-required
MarekPieta
removed
the
changelog-entry-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change deletes Fast Pair storage manager's "reset" flag instead of storing it as false to ensure no data is left in settings after a successful factory reset operation.
PR also aligns the Fast Pair factory reset unit test.
Jira: NCSDK-20219