wifi: Radio test combo 5340 #11710
Closed
wifi: Radio test combo 5340 #11710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krish2718
requested review from
bama-nordic,
sachinthegreen and
a team
as code owners
github-actions
bot
added
the
changelog-entry-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
krish2718
force-pushed
the
radio_test_combo_5340
branch
from
4b4161d
to
41d70ef
Compare
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
Add a Kconfig option to choose to build for a combo build for nRF700x radio test. As we intend use the define in this file, it cannot be defined under samples/wifi/radio_test. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
Wi-Fi radio test combo build is disabled by default and if enabled has to pull in the peripheral radio test child image to CPUNET for nRF5340. This is controlled by used of CPUNET configuration, but due to the mismatch in choosing different Kconfig options RPMSG child image vs. Peripheral radio test image, the partition manager is enabled because radio test sample is enabled, but no child image is enabled as CPUNET is disabled. Fix this by using the newly add macro that takes care of all dependencies. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
Use newly introduced combo build. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
This helps us catch issues with combo builds on RF5340, primarily for storing FW patches in external flash. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
force-pushed
the
radio_test_combo_5340
branch
from
41d70ef
to
e3ec117
Compare
sachinthegreen
approved these changes
Jul 10, 2023
bama-nordic
approved these changes
Jul 10, 2023
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to demonstrate the twister failure, once we solve the issue then fix will be updated.