Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Llpm sample connect directly to 1ms #11750

Merged

Conversation

martintv
Copy link
Contributor

@martintv martintv commented Jul 8, 2023

samples: bluetooth: Connect directly to 1ms in llpm sample

This improves speed of setting up encryption and doing service discovery by alot.

doing the minimum now in this PR, we can probably also get rid of the vs hci command (SDC_HCI_OPCODE_CMD_VS_CONN_UPDATE) and use the zephyr funciton to change connection interval now. but that will be in a later PR

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jul 8, 2023
@martintv martintv force-pushed the llpm_sample_connect_directly_to_1ms branch 2 times, most recently from 64fb340 to e4e1471 Compare July 8, 2023 12:38
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jul 8, 2023

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
zephyr nrfconnect/sdk-zephyr@c60f4de nrfconnect/sdk-zephyr#1246 nrfconnect/sdk-zephyr#1246/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@martintv martintv force-pushed the llpm_sample_connect_directly_to_1ms branch 3 times, most recently from 8ee9124 to 83ce680 Compare July 14, 2023 21:11
@martintv martintv marked this pull request as ready for review July 26, 2023 08:43
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jul 26, 2023

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-ble X
test-fw-nrfconnect-ble_samples X
test-fw-nrfconnect-chip X
test-fw-nrfconnect-fem X
test-fw-nrfconnect-rs X
test-fw-nrfconnect-zigbee X
test-sdk-find-my X
test-sdk-homekit X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@martintv martintv force-pushed the llpm_sample_connect_directly_to_1ms branch from 83ce680 to 774d8ff Compare July 26, 2023 09:49
@martintv martintv force-pushed the llpm_sample_connect_directly_to_1ms branch from 774d8ff to 6db60f8 Compare July 31, 2023 08:56
@github-actions github-actions bot removed the manifest label Jul 31, 2023
Copy link
Contributor

@KAGA164 KAGA164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the sample doc and fix typos in the commit message

samples/bluetooth/llpm/src/main.c Show resolved Hide resolved
samples/bluetooth/llpm/src/main.c Show resolved Hide resolved
samples/bluetooth/llpm/src/main.c Outdated Show resolved Hide resolved
@martintv martintv force-pushed the llpm_sample_connect_directly_to_1ms branch from 6db60f8 to b7dbc1a Compare August 10, 2023 10:12
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Aug 10, 2023
@martintv martintv force-pushed the llpm_sample_connect_directly_to_1ms branch from b7dbc1a to 0408985 Compare August 10, 2023 10:22
samples/bluetooth/llpm/README.rst Outdated Show resolved Hide resolved
samples/bluetooth/llpm/README.rst Outdated Show resolved Hide resolved
samples/bluetooth/llpm/README.rst Outdated Show resolved Hide resolved
samples/bluetooth/llpm/README.rst Outdated Show resolved Hide resolved
@martintv martintv force-pushed the llpm_sample_connect_directly_to_1ms branch 2 times, most recently from 6ab4bc4 to 7635776 Compare August 10, 2023 11:37
@martintv martintv force-pushed the llpm_sample_connect_directly_to_1ms branch from 7635776 to d31c4f0 Compare August 10, 2023 12:29
Instad of connecting to 7.5ms and then changing to 1ms.
Speeds up encryption setup and service discovery by alot.

Signed-off-by: Martin Tverdal <martin.tverdal@nordicsemi.no>
@martintv martintv force-pushed the llpm_sample_connect_directly_to_1ms branch from d31c4f0 to 535aecf Compare August 11, 2023 07:14
@rlubos rlubos removed the DNM label Aug 11, 2023
@rlubos
Copy link
Contributor

rlubos commented Aug 11, 2023

There's no more manifest changes in the PR, removed DNM.

@rlubos rlubos merged commit 0520999 into nrfconnect:main Aug 11, 2023
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval. manifest-zephyr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants