Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFC shell #11790

Merged
merged 3 commits into from
Aug 3, 2023
Merged

NFC shell #11790

merged 3 commits into from
Aug 3, 2023

Conversation

KAGA164
Copy link
Contributor

@KAGA164 KAGA164 commented Jul 12, 2023

This PR contains:

  • NFC T4T ISO-DEP shell backend module
  • NFC shell sample that is an example for the user how to use NFC shell backend

@github-actions github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval. labels Jul 12, 2023
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jul 12, 2023

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-nfc X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

Copy link
Contributor

@dchat-nordic dchat-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code side lgtm.

doc/nrf/libraries/shell/shell_nfc.rst Outdated Show resolved Hide resolved
subsys/shell/shell_nfc.c Show resolved Hide resolved
subsys/shell/shell_nfc.c Show resolved Hide resolved
subsys/shell/Kconfig Outdated Show resolved Hide resolved
subsys/shell/Kconfig Outdated Show resolved Hide resolved
doc/nrf/libraries/shell/shell_nfc.rst Outdated Show resolved Hide resolved
doc/nrf/libraries/shell/shell_nfc.rst Outdated Show resolved Hide resolved
@maje-emb maje-emb requested a review from annakielar July 18, 2023 07:22
@maje-emb
Copy link
Contributor

I think it is worth updating the release-notes-changelog file.

@github-actions github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jul 25, 2023
@KAGA164
Copy link
Contributor Author

KAGA164 commented Jul 25, 2023

I think it is worth updating the release-notes-changelog file.
@maje-emb I agree, added

@KAGA164 KAGA164 requested a review from maje-emb July 25, 2023 13:49
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

Copy link
Contributor

@annakielar annakielar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Kamil, please take a look at my suggestions.

I unified the naming convention based on this page: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/latest/nrf/protocols/nfc/index.html

doc/nrf/libraries/shell/shell_nfc.rst Outdated Show resolved Hide resolved
doc/nrf/libraries/shell/shell_nfc.rst Outdated Show resolved Hide resolved
samples/nfc/shell/README.rst Outdated Show resolved Hide resolved
samples/nfc/shell/README.rst Outdated Show resolved Hide resolved
doc/nrf/libraries/shell/shell_nfc.rst Outdated Show resolved Hide resolved
samples/nfc/shell/README.rst Outdated Show resolved Hide resolved
samples/nfc/shell/README.rst Outdated Show resolved Hide resolved
samples/nfc/shell/README.rst Outdated Show resolved Hide resolved
samples/nfc/shell/README.rst Outdated Show resolved Hide resolved
samples/nfc/shell/README.rst Outdated Show resolved Hide resolved
doc/nrf/libraries/shell/shell_nfc.rst Outdated Show resolved Hide resolved
doc/nrf/libraries/shell/shell_nfc.rst Outdated Show resolved Hide resolved
doc/nrf/libraries/shell/shell_nfc.rst Outdated Show resolved Hide resolved
doc/nrf/libraries/shell/shell_nfc.rst Outdated Show resolved Hide resolved
subsys/shell/Kconfig Outdated Show resolved Hide resolved
subsys/shell/shell_nfc.c Outdated Show resolved Hide resolved
subsys/shell/shell_nfc.c Outdated Show resolved Hide resolved
subsys/shell/shell_nfc.c Show resolved Hide resolved
samples/nfc/shell/README.rst Outdated Show resolved Hide resolved
doc/nrf/libraries/shell/shell_nfc.rst Outdated Show resolved Hide resolved
doc/nrf/libraries/shell/shell_nfc.rst Outdated Show resolved Hide resolved
doc/nrf/libraries/shell/shell_nfc.rst Outdated Show resolved Hide resolved
doc/nrf/libraries/shell/shell_nfc.rst Outdated Show resolved Hide resolved
doc/nrf/libraries/shell/shell_nfc.rst Show resolved Hide resolved
doc/nrf/libraries/shell/shell_nfc.rst Outdated Show resolved Hide resolved
samples/nfc/shell/README.rst Outdated Show resolved Hide resolved
samples/nfc/shell/README.rst Outdated Show resolved Hide resolved
samples/nfc/shell/README.rst Outdated Show resolved Hide resolved
This adds the new NFC T4T shell backend.
The transport interface uses raw ISO-DEP
protocol to exchange data with a reader device.

NCSDK-22428

Signed-off-by: Kamil Gawor <Kamil.Gawor@nordicsemi.no>
Add documentation for NFC shell transport feature.

NCSDK-22428

Signed-off-by: Kamil Gawor <Kamil.Gawor@nordicsemi.no>
Add new NFC shell sample that demonstrates how to use
shell over NFC T4T ISO-DEP transport.

NCSDK-22428

Signed-off-by: Kamil Gawor <Kamil.Gawor@nordicsemi.no>
@nordicjm nordicjm merged commit ddb40f7 into nrfconnect:main Aug 3, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants