Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards: Align the nRF21540 EK names with the new convention #11831

Merged
merged 2 commits into from
Aug 3, 2023
Merged

boards: Align the nRF21540 EK names with the new convention #11831

merged 2 commits into from
Aug 3, 2023

Conversation

maje-emb
Copy link
Contributor

According to the new naming convention there should be no '_' characters in the board names.

@github-actions github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval. labels Jul 19, 2023
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jul 19, 2023 •
edited
Loading

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
desktop52_verification X
test-fw-nrfconnect-ble X
test-fw-nrfconnect-ble_samples X
test-fw-nrfconnect-chip X
test-fw-nrfconnect-proprietary_esb X
test-fw-nrfconnect-zigbee X
test-sdk-audio X
test-sdk-homekit X

test-sdk-homekit: added because there was no .github/test-spec.yml in 'homekit'

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

KAGA164
KAGA164 reviewed Jul 19, 2023
View reviewed changes
Copy link
Contributor

@KAGA164 KAGA164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested these changes. They looks good. I think that it is worth to put note about this shield name change in the changelog since it affects build command for many subsystems

grochu
grochu approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@grochu grochu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@github-actions github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jul 19, 2023
@maje-emb maje-emb requested a review from annakielar July 19, 2023 14:29
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 1, 2023 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
homekit https://github.com/nrfconnect/sdk-homekit/commit/77828c53c0753083e27f702801ac34cc56bc5c7b https://github.com/nrfconnect/sdk-homekit/commit/b58f49933e66903e7508cc763e01043f2fd64bd2 (main) nrfconnect/sdk-homekit@77828c53..b58f4993

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@maje-emb
boards: Align the nRF21540 EK names with the new convention
5c80c53 
According to the new naming convention there should be no '_'
characters in the board names.

Ref: NCSDK-22226

Signed-off-by: Marcin Jelinski <marcin.jelinski@nordicsemi.no>
@maje-emb
changelog: Update the changelog with name change nRF21540 EK shield
82c909e 
Adds entry to changelog about name changes nRF21540 EK shield.

Signed-off-by: Marcin Jelinski <marcin.jelinski@nordicsemi.no>
@NordicBuilder NordicBuilder removed the DNM label Aug 2, 2023
@nordicjm nordicjm merged commit 0cf60a3 into nrfconnect:main Aug 3, 2023
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annakielar annakielar annakielar approved these changes

@dchat-nordic dchat-nordic dchat-nordic approved these changes

@KAGA164 KAGA164 KAGA164 approved these changes

@alexsven alexsven alexsven approved these changes

@MarekPieta MarekPieta MarekPieta approved these changes

@grochu grochu grochu approved these changes

@doki-nordic doki-nordic Awaiting requested review from doki-nordic

@tomchy tomchy Awaiting requested review from tomchy

@sebastiandraus sebastiandraus Awaiting requested review from sebastiandraus

@lemrey lemrey Awaiting requested review from lemrey

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@alwa-nordic alwa-nordic Awaiting requested review from alwa-nordic

@carlescufi carlescufi Awaiting requested review from carlescufi

@tejlmand tejlmand Awaiting requested review from tejlmand

@anangl anangl Awaiting requested review from anangl

@koffes koffes Awaiting requested review from koffes

@erikrobstad erikrobstad Awaiting requested review from erikrobstad

@rick1082 rick1082 Awaiting requested review from rick1082

@gWacey gWacey Awaiting requested review from gWacey

@jori-nordic jori-nordic Awaiting requested review from jori-nordic

Assignees
No one assigned
Labels
doc-required PR must not be merged without tech writer approval. manifest manifest-homekit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@maje-emb @NordicBuilder @grochu @MarekPieta @alexsven @KAGA164 @dchat-nordic @annakielar @nordicjm