partition_manager: Move misplaced size statement in pm.yml.settings #11848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
All integration tests: null Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
hellesvik-nordic
approved these changes
Jul 21, 2023
sigvartmh
approved these changes
Jul 21, 2023
osaether
force-pushed
the
pm_yml_move_endif
branch
from
dcdfcc6
to
160833f
Compare
osaether
force-pushed
the
pm_yml_move_endif
branch
2 times, most recently
from
feeec9a
to
49d4d7e
Compare
Move the size statement outside the ifdef since it must be set in both cases. Ref: NCSIDB-1012 Signed-off-by: Ole Sæther <ole.saether@nordicsemi.no>
osaether
force-pushed
the
pm_yml_move_endif
branch
from
49d4d7e
to
73620e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the size statement outside the ifdef since it must be set in both cases.
Ref: NCSIDB-1012