samples: crypto: psa_tls: Don't test secure-only nrf91 #11862
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't test secure-only nrf91 with psa_tls. NCS applications must use non-secure nrf91 due to a HW limitation in nrf91. For this reason all nrf9160 samples test only against nrf91_ns and not nrf91 secure-only. The only reason to test secure-only would be to test a library that would be used by a bootloader, but I can't imagine a bootloader would be doing psa_tls so skip this testing. Omitting this testing will reduce CI load and decrease maintenance cost. Signed-off-by: Sebastian Bøe <sebastian.boe@nordicsemi.no>
SebastianBoe
requested review from
frkv,
Vge0rge,
vili-nordic,
joerchan and
mswarowsky
as code owners
github-actions
bot
added
the
changelog-entry-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
Vge0rge
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
I added @stephen-nordic here since it's useful for him to know.
|
waiting for review from @magnev |
|
this change was not very popular |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't test secure-only nrf91 with psa_tls. NCS applications must use non-secure nrf91 due to a HW limitation in nrf91.
For this reason all nrf9160 samples test only against nrf91_ns and not nrf91 secure-only.
The only reason to test secure-only would be to test a library that would be used by a bootloader, but I can't imagine a bootloader would be doing psa_tls so skip this testing.
Omitting this testing will reduce CI load and decrease maintenance cost.