drivers: wifi: Disable TCP/IP checksum offload with IP fragmentation #11876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When IP fragementation is enabled, the checksum needs to computed before fragmentation and verified only after re-assembly, but as fragmentation/re-assembly are done in Zephy, offloaded checksum won't work. Till we figure out a permanent solution for this, disable checksum offload when IP fragmentation is enabled. Fixes SHEL-1800. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
requested review from
ajayparida,
udaynordic,
krga2022,
divyagona,
lakshmi-nagumothu and
VivekUppunda
krish2718
requested review from
sachinthegreen,
rado17 and
rlubos
as code owners
github-actions
bot
added
the
changelog-entry-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
VivekUppunda
approved these changes
Jul 26, 2023
udaynordic
approved these changes
Jul 26, 2023
rlubos
approved these changes
Jul 26, 2023
sachinthegreen
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When IP fragementation is enabled, the checksum needs to computed before fragmentation and verified only after re-assembly, but as fragmentation/re-assembly are done in Zephy, offloaded checksum won't work.
Till we figure out a permanent solution for this, disable checksum offload when IP fragmentation is enabled.
Fixes SHEL-1800.