-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: lib: nrf_cloud: add missing AIR_QUAL handler to shadow encoder #11914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glarsennordic
requested review from
plskeggs,
jayteemo,
rlubos and
carlescufi
as code owners
July 31, 2023 19:06
github-actions
bot
added
the
doc-required
PR must not be merged without tech writer approval.
label
Jul 31, 2023
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
jayteemo
approved these changes
Jul 31, 2023
wiba-nordic
requested changes
Aug 2, 2023
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
wiba-nordic
approved these changes
Aug 7, 2023
peknis
requested changes
Aug 8, 2023
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
plskeggs
approved these changes
Aug 8, 2023
peknis
approved these changes
Aug 9, 2023
Prior to this commit, nrf_cloud_encode_service_info_ui erroneously ignores the air_quality member of nrf_cloud_svc_info_ui. This commit adds the missing handler, so that AIR_QUALITY is correctly enabled when updating shadow. IRIS-6724 Signed-off-by: Georges Oates_Larsen <georges.larsen@nordicsemi.no>
glarsennordic
force-pushed
the
IRIS6724
branch
from
August 10, 2023 17:32
ec9cbcf
to
ab94cba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, nrf_cloud_encode_service_info_ui erroneously ignores the air_quality member of nrf_cloud_svc_info_ui. This commit adds the missing handler, so that AIR_QUALITY is correctly enabled when updating shadow.
IRIS-6724