Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: lib: nrf_cloud: add missing AIR_QUAL handler to shadow encoder #11914

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

glarsennordic
Copy link
Contributor

Prior to this commit, nrf_cloud_encode_service_info_ui erroneously ignores the air_quality member of nrf_cloud_svc_info_ui. This commit adds the missing handler, so that AIR_QUALITY is correctly enabled when updating shadow.

IRIS-6724

@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Jul 31, 2023
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jul 31, 2023

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-ci-nrfconnect-boot-fw-update X
test-fw-nrfconnect-nrf-iot_cloud X
test-fw-nrfconnect-nrf-iot_mosh X
test-fw-nrfconnect-nrf-iot_positioning X
test-fw-nrfconnect-nrf-iot_serial_lte_modem X
test-fw-nrfconnect-nrf-iot_thingy91 X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

Prior to this commit, nrf_cloud_encode_service_info_ui erroneously
ignores the air_quality member of nrf_cloud_svc_info_ui. This commit
adds the missing handler, so that AIR_QUALITY is correctly enabled when
updating shadow.

IRIS-6724

Signed-off-by: Georges Oates_Larsen <georges.larsen@nordicsemi.no>
@nordicjm nordicjm merged commit 072f7fb into nrfconnect:main Aug 11, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants