Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applications: nrf_desktop: Avoid BLE scan stop on HID output report #11950

Merged
merged 1 commit into from
Aug 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions applications/nrf_desktop/src/modules/ble_scan.c
Original file line number Diff line number Diff line change
Expand Up @@ -516,6 +516,13 @@ static bool app_event_handler(const struct app_event_header *aeh)
static bool ble_bond_ready;

if (is_hid_report_event(aeh)) {
const struct hid_report_event *event = cast_hid_report_event(aeh);

/* Ignore HID output reports. Subscriber is NULL for a HID output report. */
if (!event->subscriber) {
return false;
}

/* Do not scan when devices are in use. */
scan_counter = 0;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,9 @@ nRF Desktop
* To improve the accuracy, the generation of simulated movement data in the :ref:`nrf_desktop_motion` now uses a timestamp in microseconds based on the cycle count (either :c:func:`k_cycle_get_32` or :c:func:`k_cycle_get_64` function depending on the :kconfig:option:`CONFIG_TIMER_HAS_64BIT_CYCLE_COUNTER` Kconfig option).
* Aligned Kconfig option names in the :ref:`nrf_desktop_motion` implementation that generates motion from button presses.
The Kconfig options defining used key IDs are prefixed with ``CONFIG_MOTION_BUTTONS_`` instead of ``CONFIG_MOTION_`` to ensure consistency with configuration of other implementations of the motion module.
* The :ref:`nrf_desktop_ble_scan` no longer stops Bluetooth LE scanning when it receives :c:struct:`hid_report_event` related to a HID output report.
Sending HID output report is triggered by a HID host.
Scanning stop may lead to an edge case where the scanning is stopped, but there are no peripherals connected to the dongle.

Thingy:53: Matter weather station
---------------------------------
Expand Down
Loading