Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: lib: nrf_cloud: filter local APs from Wi-Fi location req #11988

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

jayteemo
Copy link
Contributor

@jayteemo jayteemo commented Aug 8, 2023

Do not include access points with local MAC addresses in nRF Cloud location requests. The cloud will discard them.

Consolidate location request message generation into one function, nrf_cloud_obj_location_request_payload_add(), and remove nrf_cloud_location_req_json_encode().

IRIS-6733

@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Aug 8, 2023
@jayteemo jayteemo force-pushed the IRIS-6733 branch 3 times, most recently from 408e8a8 to b6ac422 Compare August 8, 2023 23:45
@jayteemo jayteemo marked this pull request as ready for review August 8, 2023 23:53
Copy link
Contributor

@plskeggs plskeggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 9, 2023

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-ci-nrfconnect-boot-fw-update X
test-fw-nrfconnect-nrf-iot_cloud X
test-fw-nrfconnect-nrf-iot_mosh X
test-fw-nrfconnect-nrf-iot_positioning X
test-fw-nrfconnect-nrf-iot_serial_lte_modem X
test-fw-nrfconnect-nrf-iot_thingy91 X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@jayteemo jayteemo requested a review from peknis August 9, 2023 05:57
include/net/nrf_cloud_rest.h Outdated Show resolved Hide resolved
subsys/net/lib/nrf_cloud/src/nrf_cloud_codec_internal.c Outdated Show resolved Hide resolved
subsys/net/lib/nrf_cloud/src/nrf_cloud_codec_internal.c Outdated Show resolved Hide resolved
Do not include access points with local MAC addresses in
nRF Cloud location requests. The cloud will discard them.

Consolidate location request message generation into one
function, nrf_cloud_obj_location_request_payload_add(),
and remove nrf_cloud_location_req_json_encode().

IRIS-6733

Signed-off-by: Justin Morton <justin.morton@nordicsemi.no>
@nordicjm nordicjm merged commit 8d3c7d8 into nrfconnect:main Aug 10, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants